Replace usage of make_unique with unique_ptr for cpp11 #8763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aardappel
approved these changes
Nov 17, 2025
Collaborator
aardappel
left a comment
aardappel
left a comment
There was a problem hiding this comment.
Thanks, that's totally worth it :)
TJKoury
pushed a commit
to DigitalArsenal/flatbuffers
that referenced
this pull request
Nov 19, 2025
TJKoury
pushed a commit
to DigitalArsenal/flatbuffers
that referenced
this pull request
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would restore the ability to compile again on cpp11 if we want to go this route:
#8754 (comment)